Edgewall Software
Modify

Opened 12 years ago

Closed 12 years ago

Last modified 11 years ago

#504 closed defect (fixed)

[PATCH] problems with german umlaut and shtools.py

Reported by: anonymous Owned by:
Priority: critical Milestone: 0.6
Component: Build slave Version: dev
Keywords: shtools, slave, umlaut Cc: xieyanbo@…
Operating System: Linux

Description

i got the following error when a command executed by shtools returns a string with german umlaut in it:

2009-11-13 17:19:14 [INFO    ] suse_update_desktop_file: Ungültige Option -- c
2009-11-13 17:19:14 [ERROR   ] Internal error in build step 'build_productline'
2009-11-13 17:19:14 Traceback (most recent call last):
2009-11-13 17:19:14   File "/usr/local/lib/python2.5/site-packages/Bitten-0.7dev_r790-py2.5.egg/bitten/slave.py", line 327, in _execute_step
2009-11-13 17:19:14     step.execute(recipe.ctxt):
2009-11-13 17:19:14   File "/usr/local/lib/python2.5/site-packages/Bitten-0.7dev_r790-py2.5.egg/bitten/recipe.py", line 228, in execute
2009-11-13 17:19:14     ctxt.run(self, child.namespace, child.name, child.attr)
2009-11-13 17:19:14   File "/usr/local/lib/python2.5/site-packages/Bitten-0.7dev_r790-py2.5.egg/bitten/recipe.py", line 106, in run
2009-11-13 17:19:14     function(self, **args)
2009-11-13 17:19:14   File "/usr/local/lib/python2.5/site-packages/Bitten-0.7dev_r790-py2.5.egg/bitten/build/shtools.py", line 40, in exec_
2009-11-13 17:19:14     output=output, args=args, dir_=dir_)
2009-11-13 17:19:14   File "/usr/local/lib/python2.5/site-packages/Bitten-0.7dev_r790-py2.5.egg/bitten/build/shtools.py", line 152, in execute
2009-11-13 17:19:14     output_file.write(out + os.linesep)
2009-11-13 17:19:14 UnicodeEncodeError: 'ascii' codec can't encode character u'\xfc' in position 29: ordinal not in range(128)
2009-11-13 17:19:14 [DEBUG   ] Sending POST request to 'http://ka-sl-trac01/trac-ProductLine/builds/7/steps/'
2009-11-13 17:19:14 [WARNING ] Stopping build due to failure

Attachments (1)

bitten_shtools_codecs.patch (642 bytes) - added by Xie Yanbo <xieyanbo@…> 12 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 follow-up: Changed 12 years ago by Xie Yanbo <xieyanbo@…>

  • Cc xieyanbo@… added
  • Priority changed from major to blocker

Confirm, get the same error log when bitten client catch any UTF-8 chinese words:

[INFO    ] lib/album.py:679: [W0511] TODO
[INFO    ] lib/album.py:758: [W0511] TODO 需重构……
    step.execute(recipe.ctxt):
  File "/usr/lib64/python2.5/site-packages/bitten/recipe.py", line 228, in execute  
    ctxt.run(self, child.namespace, child.name, child.attr)
  File "/usr/lib64/python2.5/site-packages/bitten/recipe.py", line 106, in run
    function(self, **args)
  File "/usr/lib64/python2.5/site-packages/bitten/build/pythontools.py", line 127, in exec_
    file_=file_, output=output, args=args)
  File "/usr/lib64/python2.5/site-packages/bitten/build/shtools.py", line 147, in execute
    output_file.write(out + os.linesep)
UnicodeEncodeError: 'ascii' codec can't encode characters in position 40-55: ordinal not in range(128)

Using version 0.5.99 in gentoo.

comment:2 Changed 12 years ago by Xie Yanbo <xieyanbo@…>

  • Priority changed from blocker to critical

comment:3 in reply to: ↑ 1 Changed 12 years ago by Xie Yanbo <xieyanbo@…>

Replying to Xie Yanbo <xieyanbo@…>:

Using version 0.5.99 in gentoo.

Sorry the version 0.5.99 is my home build package based on bitten trunk repository, not gentoo official package.

Changed 12 years ago by Xie Yanbo <xieyanbo@…>

comment:4 Changed 12 years ago by Xie Yanbo <xieyanbo@…>

  • Summary changed from problems with german umlaut and shtools.py to [PATCH] problems with german umlaut and shtools.py

comment:5 Changed 12 years ago by osimons

  • Milestone changed from 0.7 to 0.6

Thanks for the patch! Makes sense, tests pass, and think I'll just commit it now.

comment:6 Changed 12 years ago by osimons

  • Resolution set to fixed
  • Status changed from new to closed

Patch committed to trunk in [795] - will merge to 0.6.x shortly.

comment:7 Changed 11 years ago by osimons

#533 closed as duplicate.

Add Comment

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The ticket will remain with no owner.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.