Edgewall Software
Modify

Opened 14 years ago

Closed 14 years ago

#503 closed defect (fixed)

Wrong order of revisions shown in build configuration

Reported by: anonymous Owned by: osimons
Priority: minor Milestone: 0.6
Component: General Version: 0.6b2
Keywords: Cc: cboos, felix.schwarz@…
Operating System: Linux

Description

the Order of revisions seems not to be correct. I'm using mercurial as VC system, and the revisions listet as follows:

[99:6467f5ef1aa7] [98:50de44b5adba] [97:4db2af1cc18e] [96:d33355fc951c] [95:f0d36837a390] [94:b4a3b7d29c73] [93:525e126fc21f] [92:90e474842cbe] [91:c11578817c79] [90:81715dda7b88] [101:d0023a0fdaea] [100:f5f9a04e7467]

Thanks a lot.

Attachments (1)

bitten-503-wrong-order-of-revisions-shown-in-build-configuration.patch (3.7 KB) - added by Felix Schwarz <felix.schwarz@…> 14 years ago.
This patch fixes the issue - basically bitten must not sort revisions, they are already sorted in the correct order when Trac returns them.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 14 years ago by cboos

  • Cc cboos added

comment:2 Changed 14 years ago by anonymous

I second this (using git). The order is correct in the flash charts though!

comment:3 Changed 14 years ago by Felix Schwarz <felix.schwarz@…>

  • Cc felix.schwarz@… added

Changed 14 years ago by Felix Schwarz <felix.schwarz@…>

This patch fixes the issue - basically bitten must not sort revisions, they are already sorted in the correct order when Trac returns them.

comment:4 Changed 14 years ago by Felix Schwarz <felix.schwarz@…>

You might want to do some cleanup in the web_ui tests - I feel they are quite repetitive for what they are doing. However I wanted to keep to patch minimal.

Actually I'd like to see this bug fixed also in the next 0.6 beta. What's the process of nominating a bug for that milestone?

comment:5 Changed 14 years ago by osimons

  • Milestone changed from 0.6.1 to 0.6

I've read through the patch, and applied it on my Subversion test project without seeing any change in the sort order - which is good :-) Unfortunately I do not have a testing setup with Mercurial and/or Git, but if anyone can verify the patch I'll have no problems with applying it now before 0.6.

comment:6 Changed 14 years ago by Felix Schwarz <felix.schwarz@…>

I'd like to see more verifications as well but at least it works on my Trac projects, e.g. pycerberus. Note the order of '99:…' -> '100…' which was wrong before (because '100:' < '99:').

comment:7 Changed 14 years ago by osimons

  • Owner set to osimons

Thanks a lot, Felix! Nothing to be gained from waiting more, so just applying the patch seems to work fine - with a unittest to boot :-)

Committed in [890] and updated milestone:0.6 with release docs.

comment:8 Changed 14 years ago by osimons

  • Resolution set to fixed
  • Status changed from new to closed

... and closing.

Add Comment

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain osimons.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.