Opened 15 years ago
Closed 15 years ago
#444 closed defect (fixed)
unused declaration in bitten.css?
| Reported by: | sanderdieleman@… | Owned by: | osimons |
|---|---|---|---|
| Priority: | trivial | Milestone: | 0.6 |
| Component: | Administration interface | Version: | dev |
| Keywords: | css | Cc: | |
| Operating System: | Linux |
Description
I was checking out Bitten's CSS because someone wants me to add some pretty colours to the test results view (right now failed testcases are bolded - he would like them to be displayed with a reddish background, and the others in green).
Much to my surprise, the <tr class="failed"/> in which failed testcases are presented already have "background: #d99;" attached to them:
line 158: #content.build table.tests tr.failed { background: #d99; }
However, the td and th elements contained therein all have their background colours set to white:
line 191: #content.build table.listing tbody th, #content.build table.listing tbody td { background: #fff; padding: .1em .3em; }
... so the #d99 doesn't seem to be doing anything. I did a quick check to see if the CSS rule applies anywhere else, but this doesn't seem to be the case; this means that it is useless and it is wasting several bytes of my precious bandwidth!
In addition, #d99 is not a very aesthetically pleasing colour. Just sayin'.
[This is a silly ticket. Osimons made me file it. I waive all responsibility.]
Attachments (0)
Change History (2)
comment:1 in reply to: ↑ description Changed 15 years ago by osimons
- Milestone set to 0.6
- Owner set to osimons
comment:2 Changed 15 years ago by osimons
- Resolution set to fixed
- Status changed from new to closed
Fixed as part of [778]. Will be merged to 0.6dev soon.
Replying to sanderdieleman@…:
Heh. Well, better fix it too then :-) During some early testing and development, I did actually see this background in use. It was horrible. It went away when failures where refactored to display in bold with marker to expand for details/traceback.
I'll remove it.