Edgewall Software
Modify ↓

Opened 15 years ago

Closed 15 years ago

#443 closed defect (fixed)

bitten-slave ignores invalid --config path

Reported by: sanderdieleman@… Owned by: osimons
Priority: minor Milestone: 0.6
Component: Build slave Version: 0.5.3
Keywords: slave configuration Cc:
Operating System: Linux

Description

When bitten-slave is executed with the -f or --config parameter, and an invalid path (to a nonexistent file) is provided as its argument, this is silently ignored.

bitten-slave proceeds to run, but the configuration sent to the server is unmodified (because supposedly, no configuration file was provided).

Instead of this, it should at the very least print a warning.

Attachments (1)

t443-config_not_found-r748.diff​ (3.3 KB) - added by osimons 15 years ago.
Throw error and exit if specified configuration file isn't found.

Download all attachments as: .zip

Change History (3)

Changed 15 years ago by osimons

Throw error and exit if specified configuration file isn't found.

comment:1 Changed 15 years ago by osimons

  • Milestone changed from 0.6.1 to 0.6
  • Owner set to osimons

I agree. A configuration may contain important information for connecting and executing the build, and if one is specified but not found then that should be a reason just to abort.

I've attached a patch for this. I'll commit it soon unless anyone has comments or see better ways of doing this.

comment:2 Changed 15 years ago by osimons

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in [749].

Add Comment

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain osimons.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.