Build system output is not sanitized in log

[TimN]

Bitten does not sanitize the logout output it sends after a successful step.

Our build system gives colored output on the console to make it easy to see at a glance what's going on. This prodocues strings like \033[1;30m in the output, where \033 is translated into the literal value 33 (not-printable character). This causes the xmlio.parse() call to fail and thus even though the build was successful it is not entered as such in the database. A 400 Bad Request (XML parser error) is returned instead.

The output should be sanitized to be XML compliant before it is sent. Even cooler would be if it understood the console color codes and translated them into HTML color codes such that the output looks the same on the build status page.

[mgood]

This could also be seen as a bug in the build tool for sending color codes when the output is not a TTY. Is this a custom or open source build tool that could be fixed to detect when the output was a pipe instead of a terminal and supress the color codes, or is it a third-party tool?

In Python it's easy to detect whether you're printing to a terminal or a pipe with sys.stdout.isatty() and there's probably a way to do it in whatever language the build tool is implemented in:

$ python -c 'import sys; print sys.stdout.isatty()'
True
$ python -c 'import sys; print sys.stdout.isatty()' | cat
False

[jeberger@…]

See also tickets #151 and #243

[jeberger@…]

Replying to jeberger@free.fr:

See also tickets #151 and #243

And #115.

[wbell]

Fixed in [569]