Edgewall Software
Modify ↓

Opened 16 years ago

Closed 15 years ago

#209 closed defect (fixed)

Fix SourceFileLinkFormatter to work with Windows path separators

Reported by: doug.patterson Owned by: osimons
Priority: major Milestone: 0.6
Component: Trac plugin Version: dev
Keywords: windows path Cc:
Operating System: Windows

Description

Path separator replacement was done after regex, so made regex look for both types of slash. Also removed unused group.

Attachments (2)

windows_path.patch​ (491 bytes) - added by doug.patterson 16 years ago.
Patch to make Source File Link Formatter? work with Windows path separators
t209-source_link_win-r633.diff​ (2.1 KB) - added by osimons 15 years ago.
Updated patch for Windows source linking updated to current trunk, with tests.

Download all attachments as: .zip

Change History (6)

Changed 16 years ago by doug.patterson

Patch to make Source File Link Formatter? work with Windows path separators

comment:1 Changed 15 years ago by osimons

  • Owner changed from cmlenz to osimons

Thanks for the patch, and sorry for the late response. I'll put this on my todo.

comment:2 Changed 15 years ago by osimons

#319 closed as duplicate.

Changed 15 years ago by osimons

Updated patch for Windows source linking updated to current trunk, with tests.

comment:3 Changed 15 years ago by osimons

I've updated the patch to latest trunk (attachment:t209-source_link_win-r633.diff​ - which is a naming mistake as it should be r663...), and added some tests for it.

Anyone feel like reading/testing before I commit?

comment:4 Changed 15 years ago by osimons

  • Resolution set to fixed
  • Status changed from new to closed

Patch committed in [667]. Thanks!

Add Comment

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain osimons.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.