Opened 15 years ago
Closed 14 years ago
#577 closed defect (fixed)
Do not convert version to int, fails on mercurial
| Reported by: | simohe@… | Owned by: | dfraser |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.6 |
| Component: | Trac plugin | Version: | dev |
| Keywords: | report coverage | Cc: | felix.schwarz@…, dfraser |
| Operating System: | Linux |
Description
Please do not convert the version to an int in http://bitten.edgewall.org/browser/trunk/bitten/report/coverage.py#L213
DVS like mercurial do not have numeric versions.
Attachments (0)
Change History (5)
comment:1 Changed 14 years ago by Felix Schwarz <felix.schwarz@…>
- Cc felix.schwarz@… added
comment:2 follow-up: ↓ 3 Changed 14 years ago by osimons
- Cc dfraser added
- Milestone changed from 0.6.1 to 0.6
comment:3 in reply to: ↑ 2 Changed 14 years ago by dfraser
Replying to osimons:
You are right, that does not look like a good idea. It seems to be changed in [846] as part of the charting code, but not quite sure why it got changed in this way.
I'll add dfraser to this ticket, maybe he can provide some insight.
Ah, I can see that this would cause problems with mercurial.
The reason it was done is so that the charting produces an X axis proportional to the revision number. I'm not sure how well it would work with a sequence of strings for the X axis - could you test with your mercurial installation and check that it still shows the revision numbers in sequence on the X axis? If so I'd happily remove that.
comment:4 Changed 14 years ago by osimons
- Owner set to dfraser
BTW, see #503 for related details of revision sorting.
comment:5 Changed 14 years ago by dfraser
- Resolution set to fixed
- Status changed from new to closed
You are right, that does not look like a good idea. It seems to be changed in [846] as part of the charting code, but not quite sure why it got changed in this way.
I'll add dfraser to this ticket, maybe he can provide some insight.