Edgewall Software
Modify

Opened 17 years ago

Closed 15 years ago

#241 closed defect (fixed)

[PATCH] Builds should be done in chronological order.

Reported by: jeberger@… Owned by: osimons
Priority: major Milestone: 0.6
Component: Build master Version: 0.5.3
Keywords: Cc:
Operating System: Linux

Description

Problem description

Currently, builds are done in the order in which configurations appear on the administrative interface. This means that if the first configuration is under very active development with frequent commits, it can prevent other configurations from being built, effectively acting as a DOS attack for the other builds. This is especially true if this configuration is long to build, as this will increase the probability that a commit will be done while the configuration is being built, thus triggering a new build of the same configuration immediately after the current one finishes and before other configurations have a chance to run.

Suggested fix

If builds were done in chronological order, older revisions of other configurations would get a chance to be built even if the first configuration is under very active development.

The attached patch is one way to do it.

Attachments (1)

bitten-sort-builds-by-date.patch (571 bytes) - added by jeberger@… 17 years ago.
Patch against trunk revision 519

Download all attachments as: .zip

Change History (4)

Changed 17 years ago by jeberger@…

Patch against trunk revision 519

comment:1 Changed 17 years ago by jeberger@…

  • Summary changed from Builds should be done in chronological order. to [PATCH] Builds should be done in chronological order.

comment:2 Changed 15 years ago by osimons

  • Owner changed from cmlenz to osimons

Agree. Patch looks good. I'll test it.

comment:3 Changed 15 years ago by osimons

  • Resolution set to fixed
  • Status changed from new to closed

Patch committed in [647]. Thanks!

Add Comment

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain osimons.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.