Edgewall Software

Opened 12 years ago

Closed 9 years ago

#222 closed defect (fixed)

Slave connection timeout incorrectly measured

Reported by: dabrahams Owned by: hodgestar
Priority: major Milestone: 0.6
Component: Build master Version: 0.6b2
Keywords: Cc:
Operating System:


The description of the slave connection timeout is "The timeout in seconds after which a build started by a slave is considered aborted, in case there has been no activity from that slave in that time," but in fact Bitten measures the time from the beginning of the build. If you have enough short steps, it's easy for a slave to exceed any given timeout without actually being unresponsive.

Attachments (4)

0007-Add-new-last_activity-field-to-build.-I-considered-r.diff (11.2 KB) - added by hodgestar 9 years ago.
Walter's patch.
0007-Add-new-last_activity-field-to-build.-I-considered-r.patch (11.2 KB) - added by wbell 9 years ago.
One more try.
0007-Add-new-last_activity-field-to-build.-I-considered-r.2.patch (12.0 KB) - added by wbell 9 years ago.
last_activity_patch_v3.diff (10.8 KB) - added by hodgestar 9 years ago.
Fixed up database upgrade script, few other minor tweaks.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 10 years ago by osimons

  • Milestone changed from 0.6 to 0.6.1

comment:2 Changed 9 years ago by hodgestar

  • Milestone changed from 0.6.1 to 0.6
  • Operating System BSD deleted
  • Owner changed from cmlenz to hodgestar
  • Status changed from new to assigned
  • Version changed from 0.5.3 to 0.6b2

Patch from Walter being added shortly. Walter's notes:

Add new last_activity field to build. I considered reusing stopped, but this seemed cleaner and more obvious, which seems like the right way to go.

On the completion of every step, last activity is updated to the current time. All orphaning/invalidation based on slave_timeout happens based on that time, not started. Previously, builds were orphaned if it had been more than slave_timeout (config setting) seconds since they had started, now it's since the last interaction (which is actually what the documentation on the field already says.)

This requires a database upgrade.

Changed 9 years ago by hodgestar

Walter's patch.

comment:3 Changed 9 years ago by hodgestar

See also #411.

Changed 9 years ago by hodgestar

Fixed up database upgrade script, few other minor tweaks.

comment:4 Changed 9 years ago by wbell

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed as of [840]

Add Comment

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain hodgestar.
The resolution will be deleted. Next status will be 'reopened'.

E-mail address and user name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.