Modify ↓
Opened 17 years ago
Closed 15 years ago
#222 closed defect (fixed)
Slave connection timeout incorrectly measured
| Reported by: | dabrahams | Owned by: | hodgestar |
|---|---|---|---|
| Priority: | major | Milestone: | 0.6 |
| Component: | Build master | Version: | 0.6b2 |
| Keywords: | Cc: | ||
| Operating System: |
Description
The description of the slave connection timeout is "The timeout in seconds after which a build started by a slave is considered aborted, in case there has been no activity from that slave in that time," but in fact Bitten measures the time from the beginning of the build. If you have enough short steps, it's easy for a slave to exceed any given timeout without actually being unresponsive.
Attachments (4)
Change History (8)
comment:1 Changed 15 years ago by osimons
- Milestone changed from 0.6 to 0.6.1
comment:2 Changed 15 years ago by hodgestar
- Milestone changed from 0.6.1 to 0.6
- Operating System BSD deleted
- Owner changed from cmlenz to hodgestar
- Status changed from new to assigned
- Version changed from 0.5.3 to 0.6b2
comment:3 Changed 15 years ago by hodgestar
See also #411.
Changed 15 years ago by wbell
comment:4 Changed 15 years ago by wbell
- Resolution set to fixed
- Status changed from assigned to closed
Fixed as of [840]
Note: See
TracTickets for help on using
tickets.
Patch from Walter being added shortly. Walter's notes:
Add new last_activity field to build. I considered reusing stopped, but this seemed cleaner and more obvious, which seems like the right way to go.
On the completion of every step, last activity is updated to the current time. All orphaning/invalidation based on slave_timeout happens based on that time, not started. Previously, builds were orphaned if it had been more than slave_timeout (config setting) seconds since they had started, now it's since the last interaction (which is actually what the documentation on the field already says.)
This requires a database upgrade.