Edgewall Software
Modify ↓

Opened 17 years ago

Closed 17 years ago

#211 closed defect (fixed)

[PATCH] Fix rmtree on Windows

Reported by: doug.patterson Owned by: cmlenz
Priority: major Milestone: 0.6
Component: Build slave Version: dev
Keywords: rmtree permissions Cc:
Operating System: Windows

Description

shutil.rmtree is used to delete the build folder. After a checkout the build folder contains .svn folders that contain read-only files. On Windows Python requires write permission to delete a file or folder. The solution is to use rmtree's onerror callback to chmod files that cannot be deleted then try again.

This should fix the root cause of #183. Thanks to thomas_mueller_ffb for the link to the ​solution.

Attachments (1)

rmtree.patch​ (1.2 KB) - added by doug.patterson 17 years ago.
Patch for rmtree in slave.py

Download all attachments as: .zip

Change History (3)

Changed 17 years ago by doug.patterson

Patch for rmtree in slave.py

comment:1 Changed 17 years ago by bitten@…

The patch worked for me as I encountered this problem on Bitten r519. Seems #236 is duplicate of this bug.

comment:2 Changed 17 years ago by wbell

  • Resolution set to fixed
  • Status changed from new to closed

Closed via [521]

Add Comment

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain cmlenz.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.