AttributeError: 'NoneType' object has no attribute 'active'

[eblot]

When restarting a test session, the following traceback appears many times:

Traceback (most recent call last):
  File "/local/engine/trac/trac/web/main.py", line 511, in _dispatch_request
    dispatcher.dispatch(req)
  File "/local/engine/trac/trac/web/main.py", line 237, in dispatch
    resp = chosen_handler.process_request(req)
  File "/local/engine/bitten/bitten/master.py", line 107, in process_request
    return self._process_build_creation(req, slave_token)
  File "/local/engine/bitten/bitten/master.py", line 218, in _process_build_creation
    build = queue.get_build_for_slave(slavename, properties)
  File "/local/engine/bitten/bitten/queue.py", line 145, in get_build_for_slave
    if self.should_delete_build(build, repos):
  File "/local/engine/bitten/bitten/queue.py", line 322, in should_delete_build
    if not config.active:
AttributeError: 'NoneType' object has no attribute 'active'

Looking at the code, it seems that the culprit method is should_delete_build():

1. trunk/bitten/model.py#L149​ may return None, whereas
2. trunk/bitten/queue.py#L307​ dereference the config instance without testing for the None condition

[osimons]

So, just something like this should then be enough:

bitten/queue.py

@@ -319 +319 @@
             return True
 
         # Ignore pending builds for deactived build configs
-        if not config.active:
+        if not (config and config.active):
             self.log.info('Dropping build of configuration "%s" at '
                      'revision [%s] on %s because the configuration is '
                      'deactivated', config.name, build.rev, platform_name)

Makes sense. If the config is gone, then so should the build.

[eblot]

Replying to osimons:

So, just something like this should then be enough

Yes, I wrote my own patch the other way around (if not config or not config.active:), no more exceptions since.

[osimons]

I just spotted the subsequent logging of config.name, which may not work so well if config is None... A unittest would be quite useful to find and keep track of any pitfalls here.

[osimons]

Fixed in [972:973]. Thanks Emmanuel.