Binary files attached by Windows slave are truncated

[dave@…]

When processing an 'attach' recipe command the Bitten slave opens the file to be attached without specifying a file mode. When running on Windows this means the file is opened in text mode. As a result, all attached files get truncated at the first occurrence of a Ctrl-Z character.

A simple fix is to modify line 515 in slave.py to read:

f = open(path, 'rb')

This bug appears to still be present in trunk:

513	        log.debug('Attaching file %s to %s...', attachment.attr['filename'],
514	                                                    resource_type)
515	        f = open(path)
516	        try:
517	            data, content_type = encode_multipart_formdata({

[osimons]

Good catch, thanks! Fixed in [968] for trunk and merged to 0.6 branch in [969].