Edgewall Software
Modify ↓

Opened 14 years ago

Closed 14 years ago

#638 closed defect (fixed)

Incorrect handling of Mercurial revision in Trac 0.12

Reported by: krigstask Owned by: osimons
Priority: major Milestone: 0.6
Component: Recipe commands Version: 0.6b3
Keywords: patch, hg Cc:
Operating System: Linux

Description

When upgrading my Bitten+Trac installation to Trac 0.12 I stumbled upon the following issue.

Trac(s) 0.11 and 0.12 (or rather corresponding versions of Mercurial plugin) report Mercurial revisions differently, for example:

  • Trac 0.11: 2098:9dc8d6fd60da
  • Trac 0.12: 9dc8d6fd60da0b95ea8881f18eb803a4f78a1c6e

Due to this difference hg:pull fails here​ with IndexError: list index out of range.

Attached patch should handle both cases correctly, selecting hash in any case.

P.S. Add "Version: 0.6b3" for people to specify it in Trac.

Attachments (1)

hg_pull.trac_0.12.patch​ (468 bytes) - added by krigstask 14 years ago.
Fix hg:pull revision handling in Trac 0.12

Download all attachments as: .zip

Change History (3)

Changed 14 years ago by krigstask

Fix hg:pull revision handling in Trac 0.12

comment:1 Changed 14 years ago by osimons

  • Owner set to osimons
  • Version changed from 0.6b2 to 0.6b3

Thanks! I wasn't aware of the change, but your patch makes sense. I'll put it on todo.

comment:2 Changed 14 years ago by osimons

  • Resolution set to fixed
  • Status changed from new to closed

Thanks. Committed in [964] (trunk) and [965] (0.6-stable).

Add Comment

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain osimons.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.