OSError when you install Bitten and the snapshots directory already exists

[trac@…]

A fresh install of Bitten branches/0.6.x and the snapshots directory happens to already exist in my trac environment:

[mbooth@ic ~]$ sudo trac-admin /raid/www/trac upgrade
Traceback (most recent call last):
  File "/usr/bin/trac-admin", line 7, in ?
    sys.exit(
  File "/usr/lib/python2.4/site-packages/Trac-0.11.5multiproduct-py2.4.egg/trac/admin/console.py", line 1314, in run
    return admin.onecmd(command)
  File "/usr/lib/python2.4/site-packages/Trac-0.11.5multiproduct-py2.4.egg/trac/admin/console.py", line 133, in onecmd
    rv = cmd.Cmd.onecmd(self, line) or 0
  File "/usr/lib/python2.4/cmd.py", line 219, in onecmd
    return func(arg)
  File "/usr/lib/python2.4/site-packages/Trac-0.11.5multiproduct-py2.4.egg/trac/admin/console.py", line 1154, in do_upgrade
    self.__env.upgrade(backup=do_backup)
  File "/usr/lib/python2.4/site-packages/Trac-0.11.5multiproduct-py2.4.egg/trac/env.py", line 457, in upgrade
    participant.upgrade_environment(db)
  File "/usr/lib/python2.4/site-packages/Bitten-0.6dev-py2.4.egg/bitten/main.py", line 67, in upgrade_environment
    self.environment_created()
  File "/usr/lib/python2.4/site-packages/Bitten-0.6dev-py2.4.egg/bitten/main.py", line 51, in environment_created
    os.mkdir(snapshots_dir)
OSError: [Errno 17] File exists: '/raid/www/trac/snapshots'

[osimons]

Oh. This should not be done anymore... I think this belongs to a distant past where code snapshots where generated and sent to slaves. Searching the code for 'snapshot' I see there are some remaining instances that we should weed out (code + tests).

I'll make a patch.

[osimons]

Fixed in [908:909] for trunk and 0.6-stable. Thanks!

[osimons]

Oh. Forgot to close ticket.