Edgewall Software
Modify

Opened 9 years ago

Closed 9 years ago

#574 closed defect (fixed)

verbose flag in svntools should be converted to boolean

Reported by: Neil Muller Owned by:
Priority: minor Milestone: 0.6
Component: Recipe commands Version: 0.6b2
Keywords: Cc:
Operating System: BSD

Description

The verbose flag to the svn: commands is passed in as a string, but treated as a boolean when testing. This leads to the following recipes behaving identically:

<svn:checkout url="file:///home/neil/tmp/CTPUG/bitten-sprint/trac/test-svn"
        path="${path}" revision="${revision}" verbose="false" />

and

<svn:checkout url="file:///home/neil/tmp/CTPUG/bitten-sprint/trac/test-svn"
        path="${path}" revision="${revision}" verbose="true" />

and differing from the recipe excluding the verbose flag.

This is somewhat unexpected.

Attachments (1)

verbose.diff (755 bytes) - added by Neil Muller 9 years ago.
simple patch to verbose handling

Download all attachments as: .zip

Change History (3)

Changed 9 years ago by Neil Muller

simple patch to verbose handling

comment:1 Changed 9 years ago by Neil Muller

Simple patch to make verbose="False" work. This still accepts verbose="foo" as true, which should perhaps be flagged as an error.

comment:2 Changed 9 years ago by hodgestar

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in r847 and backported to 0.6.x in r848. Thanks for the patch!

Add Comment

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The ticket will remain with no owner.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.