Opened 15 years ago
Closed 15 years ago
#495 closed defect (fixed)
Patch for typo: Build_s_ Status in nav bar
| Reported by: | Tim Niemueller <tim@…> | Owned by: | |
|---|---|---|---|
| Priority: | trivial | Milestone: | 0.6 |
| Component: | General | Version: | dev |
| Keywords: | typo | Cc: | |
| Operating System: |
Description
The link to the Build Status page is named "Builds Status" which seems odd. The attached oneliner renames the link to Build Status. This was introduced into the 0.6.x branch with changeset r576. I guess that was unintentional, hence the patch.
Attachments (1)
Change History (4)
Changed 15 years ago by Tim Niemueller <tim@…>
comment:1 Changed 15 years ago by osimons
On my own setup I have actually changed the menu item to just read "Builds". Short and to-the-point, I think. Just offering as a suggestion as we need to change it anyway. Comments to this suggestion as default menu label? Try it out for size:
[mainnav] build.label = Builds
comment:2 Changed 15 years ago by Tim Niemueller <tim@…>
I'd prefer Build Status, but Builds would be fine as well. We have a vertical menu (see http://trac.fawkesrobotics.org), so size isn't an issue (bitten still in the phase of being configured/build slaves being prepared). I see that it matters however in the default horizontal menu bar.
The re-labeling is not an option if you want the status indication with the nav entry, because when using re-labeling the CSS style information (i.e. class) gets lost. Maybe the nav bar label should be configurable in Bitten itself, then you can have both, any label and label status indication.
comment:3 Changed 15 years ago by osimons
- Resolution set to fixed
- Status changed from new to closed
Fixed in [790:791]. Thanks!
Typo oneliner