Bitten & Trac 0.12 - "default repository" triage

[anonymous]

When trying to add a repository, autocompletion works for multirepos.

File "/usr/lib/python2.6/site-packages/Trac-0.12multirepos_r8662-py2.6.egg/trac/web/main.py", line 467, in _dispatch_request
  dispatcher.dispatch(req)
File "/usr/lib/python2.6/site-packages/Trac-0.12multirepos_r8662-py2.6.egg/trac/web/main.py", line 212, in dispatch
  resp = chosen_handler.process_request(req)
File "/usr/lib/python2.6/site-packages/Trac-0.12multirepos_r8662-py2.6.egg/trac/admin/web_ui.py", line 118, in process_request
  path_info)
File "/usr/lib/python2.6/site-packages/Bitten-0.7dev_r776-py2.6.egg/bitten/admin.py", line 195, in render_admin_panel
  config = self._create_config(req)
File "/usr/lib/python2.6/site-packages/Bitten-0.7dev_r776-py2.6.egg/bitten/admin.py", line 240, in _create_config
  warnings = self._update_config(req, config)
File "/usr/lib/python2.6/site-packages/Bitten-0.7dev_r776-py2.6.egg/bitten/admin.py", line 280, in _update_config
  node = repos.get_node(path, max_rev)

[rverchere@…]

Hi there,

get a similar issue with Trac 0.12dev-r9406 + Bitten 0.7dev-r815.

In trac 0.12dev, get_repository() takes 3 arguments :

def get_repository(self, reponame=None, authname=None):

But this as not been updated in bitten code (reponame is not present).

[victor]

Hi,

Can you fix this defect?

when use multirepos, and create new Build Configuration, trac wrote:

Attribute Error?: 'None Type?' object has no attribute 'get_node'.

Trac 0.12dev-r9593 Bitten 0.7dev-r870 Subversion 1.6.11 (r934486) mod_python 3.3.2-dev-20080819

[naxat88@…]

small hack to make integration with trac 0.12 work

[naxat88@…]

I've attached a small patch with which the integration with trac 0.12 seems to work. Unfortunately the authz-checks are ignored when using trac 0.12, since this part of the plugin-API has changed too.

[naxat88@…]

hopefully I got the permission checks now right with the new API

[osimons]

Simplified the get_repository call + removed one instance where it isn't actually used.

[osimons]

Thanks for the patch! Great work, and I've just simplified it slightly as the authname naming is unchanged from 0.11.0 we can just pass the name and it works for either regular argument or keyword argument. See attachment:t480-get_repository-r880.diff​

I'm tempted to push this patch to both trunk (0.7) and 0.6. From unittests and my inital testing with various builds and views, it makes Bitten work with Trac 0.12 using a '0.11-style setup' (just a default subversion repository). Actually supporting multirepos and all the new Trac 0.12 features is still work for a future 0.7 version of Bitten.

Further testing needed? Comments?

[silk <silk@…>]

fix permission check in timeline provider

[silk <silk@…>]

I attached an updated patch that fixes the timeline provider if repository has authz checks enabled.

+1 for commit to 0.6 and trunk

[osimons]

Compared the patches, and from what I can see all that is changed is this:

(a) v1 vs. (b) v2

@@ -134 +136 @@
 +                if not repos.authz.has_permission(path):
 +                    continue
 +            else:
-+                node = repos.get_node(config.path)
++                node = repos.get_node(path)
 +                if not node.can_view(req.perm):
 +                    continue
 +

Makes sense - Thanks!

[osimons]

Patch still has a fault in that it breaks if no default repository is present - basically self.env.get_repository() then returns None. This is now a much larger problem with new projects on 0.12 as that version not configure the "old way" anymore.

Ideas for how best to handle this is most welcome. Do we just disable Bitten and log an error for admin perhaps?

[anonymous]

Replying to osimons:

Patch still has a fault in that it breaks if no default repository is present - basically self.env.get_repository() then returns None. This is now a much larger problem with new projects on 0.12 as that version not configure the "old way" anymore.

Ideas for how best to handle this is most welcome. Do we just disable Bitten and log an error for admin perhaps?

[sahendrickson@…]

This latest patch thows an assertion error with an indication for the user to add a "(default)" repository if none exists in Trac 0.12.

In my opinion, this patch (or something similar) ought to be incorporated into a new release so that Bitten no longer breaks when installed in the current version of Trac.

Of course, a longer term solution still needs to be addressed (as mentioned in #433 and #342).

[sahendrickson@…]

updated patch to inform user of need for creating a (default) repository

[osimons]

Thanks a lot for the updated patch. It includes a lot more assert statements than I had hoped, but as they are all placed right after accessing env.get_repository() they will no doubt be picked up when we rework repository access for full 0.12 support.

I've gone through the last patch and trimmed lines to 80 chars max, tweaked tests and added a new test, and also changed the master to pass this error back to the slave as well (at least for the common 'populate' use-case).

Patch is committed in [882] (trunk) and [883] (0.6 branch).