Trac 0.12 API Change Breaks Builds

[jhampton]

In 0.12, an API change (see: ​tracd and HTTP/1.1) breaks the build master. When a slave connects, an exception is raised due to the API change.

The issue is that the Content-Length header is now required when sending data directly via the Request.

The following patch looks for the Content-Length header and sets it if it doesn't already exist, before sending data.

bitten/master.py

@@ -138 +138 @@
         """ Formats and sends the response, raising ``RequestDone``. """
         req.send_response(code)
         headers = headers or {}
+        content_length_present = False
         for header in headers:
             req.send_header(header, headers[header])
+            if 'content-length' == header.lower():
+                content_length_present = True
+            continue
+        if not content_length_present:
+            req.send_header('Content-Length', len(body))
+
         req.write(body)
         raise RequestDone

While this won't be necessary until Trac 0.12 hits the scene, it is a change that should be considered for 0.6 (and 0.11 support) as it's a good idea to make sure that the Content-Length header is set, even though Trac doesn't require it.

[osimons]

Good points. Should be fixed.

[osimons]

Fixed in [778]. Will merge to 0.6 soon.

[pipern]

This was actually fixed in [779], typo on the previous comment.