Edgewall Software
Modify

Opened 15 years ago

Closed 14 years ago

#450 closed defect (fixed)

prevnext_nav() takes at least 3 arguments (2 given)

Reported by: Olaf Meeuwissen <olaf@…> Owned by: osimons
Priority: critical Milestone: 0.6
Component: General Version: dev
Keywords: Cc:
Operating System:

Description

Just a heads up but trac:changeset:8597 breaks the /build/configuration page with a traceback. The relevant change is in trac.web.chrome.py. Basically, prevnext_nav() changed from

def prevnext_nav(req, label, uplabel=None):

to

def prevnext_nav(req, prev_label, next_label, up_label=None):

A fix would be pretty trivial if one does not have to address backward compatibility with Trac-0.11.x. But if you need to fix this so it works with that version as well as Trac's trunk, I don't see an easy fix.

Suggestions, anyone?

Attachments (1)

prevnext_nav.diff (960 bytes) - added by Olaf Meeuwissen <olaf@…> 15 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 15 years ago by osimons

I don't test Bitten with Trac trunk (0.12dev), so I won't be looking into this quite yet.

Hint: You can use trac.util.arity(fn) to get the count of arguments for the function, and pass arguments accordingly.

Changed 15 years ago by Olaf Meeuwissen <olaf@…>

comment:2 Changed 15 years ago by Olaf Meeuwissen <olaf@…>

Thanks for the clue bat.

The prevnext_nav.diff is perhaps a bit ugly but it works for me. Now Bitten trunk works with both Trac trunk before (and by extension Trac-0.11) and after the prevnext_nav() changes.

comment:3 Changed 15 years ago by cmlenz

Patch looks good to me, had to apply it to get Bitten running with Trac trunk, and it works as advertised.

comment:4 Changed 14 years ago by osimons

  • Milestone changed from 0.6.1 to 0.6
  • Owner set to osimons

Verified. Committed compat code in [801]. Will merge to 0.6.x.

comment:5 Changed 14 years ago by osimons

  • Resolution set to fixed
  • Status changed from new to closed

...and closing.

Add Comment

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain osimons.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.