bitten.ini slave name can't be overridden

[tumma72@…]

Hi all,

apparently there is a failure in the setup of the slave client, if one tries to override in the bitten.ini file the name of the "slave" machine. This is a bit annoying especially if you travel around the world with a laptop and you join various networks, that assign you alternatives hostname. Of course you could work this around by changing or not allowing the network to set your hostname, but what if other services will not work than?

Here is the trace, for now I put it here and will find a way to fix it soon, as soon as I brought our project to green again :-)

Traceback (most recent call last):
  File "/usr/local/bin/bitten-slave", line 8, in <module>
    load_entry_point('Bitten==0.6dev-r629', 'console_scripts', 'bitten-slave')()
  File "/Library/Python/2.5/site-packages/Bitten-0.6dev_r629-py2.5.egg/bitten/slave.py", line 416, in main
    exit_code = slave.run()
  File "/Library/Python/2.5/site-packages/Bitten-0.6dev_r629-py2.5.egg/bitten/slave.py", line 171, in run
    job_done = self._create_build(url)
  File "/Library/Python/2.5/site-packages/Bitten-0.6dev_r629-py2.5.egg/bitten/slave.py", line 210, in _create_build
    xml.append(xmlio.Element('package', name=package, **properties))
TypeError: type object got multiple values for keyword argument 'name'

To reproduce just create a bitten.ini file containing:

[slave]
name = anotherone

This should do :-)

[osimons]

There is a command-line option to set name - it is not possible to set it through config:

bitten-slave --name myhost ...

However, your invalid option did trigger an unwanted error that I think I'd like to clean. Basically a 'package' option cannot be called name - that should be detected and logged.

[osimons]

I've made name reserved in [660], so the error should no longer appear - instead a warning is logged and the option is gracefully skipped.