Pylint output show wrong nodes for files

[anonymous]

With Bitten r

How to reprodruce

Use this recipe :

  <step id="Checkout" description="Get source code from svn">
    <sh:exec executable="svn" args="co http://bitten.edgewall.org/svn/${path} . -r ${revision} --quiet"/>
  </step>
  <step id="Pylint" description="Pylint check" onerror="ignore">
    <sh:exec executable="pylint" args="--rcfile=pylint.rc bitten" output="build/pylint-results.out"/>
    <python:pylint file="build/pylint-results.out"/>
  </step>

This steeps works perfectly for me and i am able to see logs results and the "Code Lint" report.

The logs resuslt are perfects and clicikng on the file links display tehm correctly in Trac. But in the Code Lint report the file links are incorrects as they are mixed with local file system directories of the bitten-slave.

Exemple in log :
project/controllers/help.py:1: link correctly to the file in Trac source browser.

Same file in Code Lint result :
/home/bertrand/Mydocuments/Developpement/project/controllers/help.py link to an incorrect node because /home/bertrand/Mydocuments/Developpement/ are direcories from my slave filesystem.

PS : Just note than i use a pylint.rc file than is get from the svn project, but i do not think it's in cause.

[osimons]

Yup. Confirmed. I'll look into it.

[osimons]

This makes it work for me on Windows and OSX at least - please test:

bitten/build/pythontools.py

@@ -152 +152 @@
                     category = msg_categories.get(msg_type[0])
                     if len(msg_type) == 1:
                         msg_type = None
-                    filename = os.path.realpath(match.group('file'))
-                    if filename.startswith(ctxt.basedir):
+                    filename = match.group('file')
+                    if os.path.isabs(filename) \
+                            and filename.startswith(ctxt.basedir):
                         filename = filename[len(ctxt.basedir) + 1:]
                     filename = filename.replace(os.sep, '/')
                     lineno = int(match.group('line'))

[osimons]

Roughly same patch - but with tests to prove it :-)

[osimons]

Last patch committed in [669].