[PATCH] Add an option to prompt for a password

[mike@…]

This patch makes it so the bitten slave prompts for the password, rather than taking it on the command line (and putting it in ps).

This is useful when you don't want to put your password into a config file.

[mike@…]

Patch

[osimons]

I'll look at it.

[osimons]

Same result, but I've modified it slightly to be more rational and contained:

bitten/slave.py

@@ -358 +358 @@
                       help='the username to use for authentication')
     parser.add_option('-p', '--password', dest='password',
                       help='the password to use when authenticating')
+    def _ask_password(option, opt_str, value, parser):
+        from getpass import getpass
+        parser.values.password = getpass('Passsword: ')
+    parser.add_option('-P', '--ask-password', action='callback',
+                      callback=_ask_password, help='Prompt for password')
 
     group = parser.add_option_group('building')
     group.add_option('-d', '--work-dir', action='store', dest='work_dir',

Any comments before I commit?

[osimons]

Committed in [661]. Thanks!