Edgewall Software
Modify

Opened 15 years ago

Closed 15 years ago

#373 closed enhancement (fixed)

Global status overview in the main navigation bar

Reported by: manu.blot@… Owned by: dfraser
Priority: minor Milestone: 0.6
Component: General Version: 0.5.3
Keywords: Cc: ole@…
Operating System: BSD

Description

Something that I think is missing in the Bitten web UI is an eye-catcher to easy report a broken build to any developer browsing a Trac installation.

Here is a patch that tweaks the appearance of the Builds Status button, following the current build status.

It may be sub-optimal (and as such, not integrated into Bitten), but is quite useful to our team.

Attachments (5)

bitten-373.patch (1.6 KB) - added by manu.blot@… 15 years ago.
Patch to add a CSS class to the Builds Status button
buildcompleted.png (6.0 KB) - added by manu.blot@… 15 years ago.
Example of Builds Status button when everything is fine
buildinprogress.png (6.0 KB) - added by Emmanuel Blot <manu.blot@…> 15 years ago.
Example of the Build Status button when build is in progress
buildfailed.png (6.3 KB) - added by Emmanuel Blot <manu.blot@…> 15 years ago.
Example of Builds Status button when one or more builds are broken
b373-with-conf.diff (6.7 KB) - added by Emmanuel Blot <manu.blot@…> 15 years ago.
New version w/ configuration option

Download all attachments as: .zip

Change History (15)

Changed 15 years ago by manu.blot@…

Patch to add a CSS class to the Builds Status button

Changed 15 years ago by manu.blot@…

Example of Builds Status button when everything is fine

Changed 15 years ago by Emmanuel Blot <manu.blot@…>

Example of the Build Status button when build is in progress

Changed 15 years ago by Emmanuel Blot <manu.blot@…>

Example of Builds Status button when one or more builds are broken

comment:1 Changed 15 years ago by Emmanuel Blot <manu.blot@…>

Rendering example using the following CSS properties

#mainnav .bitteninprogress, #mainnav .bitteninprogress :hover {
  border-right: 4px solid #edd400 !important;
}
#mainnav .bittencompleted, #mainnav .bittencompleted :hover {
  border-right: 4px solid #0b0 !important;
}
#mainnav .bittenfailed, #mainnav .bittenfailed :hover {
  border-right: 4px hidden !important;
  background-color: #d99;
}
#mainnav .bittenpending, #mainnav .bittenpending :hover {
  border-right: 4px hidden !important;
}

Note that the CSS properties should be included in your site theme file or appended to the trac.css file, as the bitten.css file is not added when any page but bitten is browsed.

Example of Builds Status button when everything is fineEverything's fine
Example of the Build Status button when build is in progressBuild in progress
Example of Builds Status button when one or more builds are brokenBuild failure

comment:2 follow-up: Changed 15 years ago by dfraser

This rocks! Since the display is optional I'm sure we could get it into the main codebase - my only concern would be performance since this gets called for viewing any page.

comment:3 in reply to: ↑ 2 ; follow-up: Changed 15 years ago by Emmanuel Blot <manu.blot@…>

Replying to dfraser:

This rocks! Since the display is optional I'm sure we could get it into the main codebase - my only concern would be performance since this gets called for viewing any page.

Yes, I agree, this is what I was thinking about with "sub-optimal". It could be solved with a trac.ini option though.

comment:4 Changed 15 years ago by ole@…

  • Cc ole@… added

This is really neat. I'm certainly going to try this patch.

Cheers, Ole.

comment:5 in reply to: ↑ 3 Changed 15 years ago by dfraser

  • Owner changed from cmlenz to dfraser
  • Status changed from new to assigned

Replying to Emmanuel Blot <manu.blot@…>:

Replying to dfraser:

This rocks! Since the display is optional I'm sure we could get it into the main codebase - my only concern would be performance since this gets called for viewing any page.

Yes, I agree, this is what I was thinking about with "sub-optimal". It could be solved with a trac.ini option though.

Cool, if you can supply a patch with a trac.ini option (turned off by default for now) I'll definitely apply it

Changed 15 years ago by Emmanuel Blot <manu.blot@…>

New version w/ configuration option

comment:6 Changed 15 years ago by Emmanuel Blot <manu.blot@…>

I've attached a new version of the patch

  • Hacking of Trac CSS files is not required anymore, everything is defined within Bitten
  • A configuration option "quick_status" allows to enable or disable the feature (turning it off may improve global performances, as no request is performed on the DB when the feature is switched off)
  • Bitten master configuration settings page has been augmented w/ a check box to enable/disable this feature from the web UI

Notes:

  1. Feel free to update the variable name and the documentation (I'm not a native english speaker, as you already know ;-)). The option name has been picked up from the Trac "quick jump" feature.
  2. The bitten.css file is always included (whatever the quick status activation), as I believe there's no harm to load it w/ each page (it is saved in the browser cache anyway) and testing for the quick status activation to selectively include or exclude it would probably cost as much as always include it. Feel free to add a quick status test if you think the opposite.

comment:7 follow-up: Changed 15 years ago by Emmanuel Blot <manu.blot@…>

Addtional, off-topic note:

I've noted that Bitten does not follow Trac coding convention. Is it on purpose ?

  • mix up of tabulated indentation and space indentation (which makes the code difficult to read)
  • some lines are over 80-column wide

comment:8 Changed 15 years ago by dfraser

The patch seems malformed - I had to replace:

Index: bitten/htdocs/bitten.css
===================================================================
--- bitten/htdocs/bitten.css    (revision 629)
+++ bitten/htdocs/bitten.css    (working copy)
@@ -181,3 +181,30 @@

with:

Index: bitten/htdocs/bitten.css
===================================================================
--- bitten/htdocs/bitten.css    (revision 629)
+++ bitten/htdocs/bitten.css    (working copy)
@@ -181,3 +181,16 @@

(change the ,30 to ,16)

I'll try have a look at this soon but just wanted to check up on that... everything you said above seems cool

comment:9 in reply to: ↑ 7 Changed 15 years ago by dfraser

Replying to Emmanuel Blot <manu.blot@…>:

Addtional, off-topic note:

I've noted that Bitten does not follow Trac coding convention. Is it on purpose ?

  • mix up of tabulated indentation and space indentation (which makes the code difficult to read)
  • some lines are over 80-column wide

I don't think this is intentional and I think it would be great to move towards it - maybe you could bring this up on the mailing list?

comment:10 Changed 15 years ago by dfraser

  • Resolution set to fixed
  • Status changed from assigned to closed

Committed in r631, thanks for a great patch!

Add Comment

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain dfraser.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.