Bitten timeline event provider is broken w/ the latest Trac and Genshi dev. release

[manu.blot@…]

Since I've upgraded Trac and Genshi, the Timeline page in Trac fails with the following error:

Builds event provider (BuildController) failed:
LookupError: unknown encoding: build-project

System Information

Trac: 0.11dev-r6886
Python: 2.5 (release25-maint, Dec 9 2006, 14:35:53)
setuptools: 0.6c3
SQLite: 3.3.8
pysqlite: 2.3.2
Genshi: 0.5dev-r847
Pygments: 0.9
Subversion: 1.4.2 (r22196)
jQuery: 1.2.3

(using the branches/experimental/trac-0.11 branch)

[Emmanuel Blot <manu.blot@…>]

The Trac log shows the following details about the error:

2008-04-28 17:59:13,262 Trac[__init__] ERROR: Timeline event provider BuildController failed
Traceback (most recent call last):
  File "/home/local/engine/trac/trac/timeline/web_ui.py", line 160, in process_request
    filters):
  File "build/bdist.linux-i686/egg/bitten/web_ui.py", line 493, in get_timeline_events
    steps = [Markup('<em>%s</em>', step) for step in steps]
LookupError: unknown encoding: build-duo
2008-04-28 17:59:13,265 Trac[__init__] WARNING: 500 Trac Error (<p class="message">Builds event provider (<tt>BuildController</tt>) failed:<br/>LookupError: unknown encoding: build-duo</p><p>You may want to see the other kind of events from the <a href="/trac/fta/timeline?ticket=on&amp;changeset=on&amp;milestone=on&amp;wiki=on">Timeline</a></p>)

[Emmanuel Blot <manu.blot@…>]

With Genshi 0.5-pre, the following patch seems to work

bitten/web_ui.py

@@ -490 +490 @@
                     for step, error in errors:
                         if step not in steps:
                             steps.append(step)
-                    steps = [Markup('<em>%s</em>', step) for step in steps]
+                    steps = [Markup('<em>%s</em>' % step) for step in steps]
                     if len(steps) < 2:
                         message = steps[0]
                     elif len(steps) == 2:
@@ -498 +498 @@
                     elif len(steps) > 2:
                         message = Markup(', ').join(steps[:-1]) + ', and ' + \
                                   steps[-1]
-                    message = Markup('Step%s %s failed',
-                                     len(steps) != 1 and 's' or '', message)
+                    message = Markup('Step%s %s failed' % \
+                                     (len(steps) != 1 and 's' or '', message))
             yield event_kinds[status], href, title, stopped, None, message
 
     # Internal methods

[ebray]

This was fixed by cmlenz in r551.

[dfraser]

Replying to ebray:

This was fixed by cmlenz in r551.

Marking as fixed, then...