Edgewall Software
Modify

Opened 16 years ago

#234 new defect

tabsets don't get made properly when a tab div has no child elements (only a text node)

Reported by: J. Kyllo <jkyllo-trac@…> Owned by: cmlenz
Priority: minor Milestone:
Component: Trac plugin Version: dev
Keywords: Cc: jkyllo-trac@…
Operating System: Linux

Description

This showed itself while I was configuring a system for lint reports. With the base code the report being returned was a python "None" and so the div given to makeTab in source:trunk/bitten/htdocs/tabset.js did not have any structure to act as a title element. Because of this makeTab got all screwed up and the result was that the log from the build step was not displayed but "None" was. This is bad since, even though the report fails, the data should be available. This patch changes source:trunk/bitten/htdocs/tabset.js so that makeTab will create a new h3 element with "None" as its sole subelement. This means that the create tab will look a little weird, but at least its a tab.

There might be a better solution to this but this patch might be a start. The attached patch is against [519].

Attachments (1)

bitten-tabset.patch (843 bytes) - added by J. Kyllo <jkyllo-trac@…> 16 years ago.
A patch changing the makeTab function to create a title element if necessary.

Download all attachments as: .zip

Change History (1)

Changed 16 years ago by J. Kyllo <jkyllo-trac@…>

A patch changing the makeTab function to create a title element if necessary.

Add Comment

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain cmlenz.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.