Opened 17 years ago
#234 new defect
tabsets don't get made properly when a tab div has no child elements (only a text node)
| Reported by: | J. Kyllo <jkyllo-trac@…> | Owned by: | cmlenz |
|---|---|---|---|
| Priority: | minor | Milestone: | |
| Component: | Trac plugin | Version: | dev |
| Keywords: | Cc: | jkyllo-trac@… | |
| Operating System: | Linux |
Description
This showed itself while I was configuring a system for lint reports. With the base code the report being returned was a python "None" and so the div given to makeTab in source:trunk/bitten/htdocs/tabset.js did not have any structure to act as a title element. Because of this makeTab got all screwed up and the result was that the log from the build step was not displayed but "None" was. This is bad since, even though the report fails, the data should be available. This patch changes source:trunk/bitten/htdocs/tabset.js so that makeTab will create a new h3 element with "None" as its sole subelement. This means that the create tab will look a little weird, but at least its a tab.
There might be a better solution to this but this patch might be a start. The attached patch is against [519].
A patch changing the makeTab function to create a title element if necessary.