#103 closed defect (fixed)
os.path.commonprefix can break builds
| Reported by: | jared.jennings@… | Owned by: | cmlenz |
|---|---|---|---|
| Priority: | major | Milestone: | 0.6 |
| Component: | Build slave | Version: | dev |
| Keywords: | painting spammed | Cc: | |
| Operating System: |
Description
I had a build of a directory that contains src and docs directories. I made the recipe do a gmake -C src. I made an identical recipe for another branch of the same directory, with only a src subdirectory. The build didn't work because the slave was chdir'ing into the src directory.
I found in source:trunk/bitten/slave.py@330#L180:
basedir = os.path.join(project_dir, os.path.commonprefix(names))
I made a some_dir directory under my top directory. When the slave tried to build that one, it tried to chdir to 's' (the commonprefix of src and some_dir), which didn't exist.
It'd be more useful to me in general if (in the context of unpack_snapshot) basedir were always equal to project_dir.
Attachments (0)
Change History (5)
comment:1 Changed 18 years ago by cmlenz
- Status changed from new to assigned
comment:2 Changed 18 years ago by cmlenz
- Resolution set to fixed
- Status changed from assigned to closed
comment:4 Changed 17 years ago by anonymous
reverting spam. unfortunately i cannot remove the comment with the links.
comment:6 Changed 17 years ago by jared.jennings.ctr@…
- Keywords spammed added
Hell no, spam program, this is my ticket. Go away.
comment:7 Changed 17 years ago by cmlenz
Sorry for the noise, I've cleaned out the spam and upgraded the spam filtering now.
Should be fixed in [356].