Stopping slave while cleaning up invalidates build

[Mark Potter <mpotter@…>]

• Wanted to bring a slave host machine down for maintenance, however it was currently in the middle of a build.
• Noticed that it was near the end, so no need to waist the effort. Just wait a bit for it to finish the current build before stopping it.
• Found the specific build page (e.g. http://host/trac/build/Trunk/175219).
  • Build page indicated that the build was "In Progress".
• Wait
• Noticed build slave said "Build completed". Presumable it was cleaning up from the previous build before starting a new build.
• Refreshed build page.
  • Build page indicated that the build was now "Success".
• Stopped the build slave and started shutting down the slave host.
• Refreshed build page.
  • Build page now indicates that the build was "Pending".

Apparently when a build slave is stopped while it is building, it invalidates the current build. However, when a build slave is stopped while cleaning up, it invalidates the build that it just finished.