Edgewall Software
Modify ↓

Opened 12 years ago

Closed 12 years ago

Last modified 11 years ago

#777 closed defect (fixed)

[PATCH] slaves cannot get data from SVN with an empty password

Reported by: sam@… Owned by: hodgestar
Priority: major Milestone: 0.6.1
Component: Build slave Version: 0.6
Keywords: Cc:
Operating System: Linux

Description

If an empty password is specified in the XML configuration, eg. 

<svn:checkout url="svn://blah/" path="${path}" revision="${revision}"
              username="anonymous" password="" no_auth_cache="true" />

Then bitten-slave will prompt for a password, which is not desired. The attached patch fixes this problem.

Attachments (1)

patch-empty-password-auth.diff​ (1.3 KB) - added by sam@… 12 years ago.

Download all attachments as: .zip

Change History (6)

Changed 12 years ago by sam@…

comment:1 Changed 12 years ago by hodgestar

  • Owner set to hodgestar

Patch looks good. Just needs a test.

comment:2 Changed 12 years ago by hodgestar

  • Status changed from new to assigned

comment:3 Changed 12 years ago by hodgestar

On second thoughts, it looks like there aren't currently tests for svntools and adding them is probably tricky enough that it's outside the scope of this issue.

comment:4 Changed 12 years ago by hodgestar

  • Resolution set to fixed
  • Status changed from assigned to closed

Patch committed -- thanks!

comment:5 Changed 11 years ago by osimons

  • Milestone changed from 0.6.2 to 0.6.1

Add Comment

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain hodgestar.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.