form authentication cannot be disabled on slaves

[wbell]

The --form-auth slave configuration defaults to true and accepts no boolean parameter. This makes it impossible to disable the new behavior and go back to the old HTTP authentication default.

Probably a must fix for 0.6

[osimons]

If it is so, then that must be an implementation glitch. It is supposed to be explicitly enabled by the command-line option, defaulting to off.

[anonymous]

Setting the option default to false seems to make things work properly.

[osimons]

Looked at this, and are you sure? The commit in [722] included defaulting the setting - that should ensure that unless passed this option should default to False, no?

trunk/bitten/slave.py

@@ -404 +453 @@
     parser.set_defaults(dry_run=False, keep_files=False,
                         loglevel=logging.INFO, single_build=False, no_loop=False,
-                        dump_reports=False, interval=300)
+                        dump_reports=False, interval=300, form_auth=False)
     options, args = parser.parse_args()

[osimons]

Well, it works fine now as far as I can tell. Slave will only use form authentication when option is present.