Edgewall Software
Modify

Opened 12 years ago

Closed 12 years ago

#460 closed defect (worksforme)

form authentication cannot be disabled on slaves

Reported by: wbell Owned by: osimons
Priority: major Milestone:
Component: General Version: 0.6b2
Keywords: Cc:
Operating System: BSD

Description

The --form-auth slave configuration defaults to true and accepts no boolean parameter. This makes it impossible to disable the new behavior and go back to the old HTTP authentication default.

Probably a must fix for 0.6

Attachments (0)

Change History (4)

comment:1 Changed 12 years ago by osimons

  • Milestone changed from 0.6.1 to 0.6

If it is so, then that must be an implementation glitch. It is supposed to be explicitly enabled by the command-line option, defaulting to off.

comment:2 Changed 12 years ago by anonymous

Setting the option default to false seems to make things work properly.

comment:3 Changed 12 years ago by osimons

  • Owner set to osimons

Looked at this, and are you sure? The commit in [722] included defaulting the setting - that should ensure that unless passed this option should default to False, no?

  • trunk/bitten/slave.py

    a b  
    404453    parser.set_defaults(dry_run=False, keep_files=False,
    405454                        loglevel=logging.INFO, single_build=False, no_loop=False,
    406                         dump_reports=False, interval=300)
     455                        dump_reports=False, interval=300, form_auth=False)
    407456    options, args = parser.parse_args()

comment:4 Changed 12 years ago by osimons

  • Milestone 0.6 deleted
  • Resolution set to worksforme
  • Status changed from new to closed

Well, it works fine now as far as I can tell. Slave will only use form authentication when option is present.

Add Comment

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain osimons.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.