Bitten mixes invalid data types

[Emmanuel Blot <manu.blot@…>]

Although SQLite backend is able to cope with those type mistmaches, when Trac is using a PostgreSQL backend, Bitten prevents Trac from initialiazing properly.

• bitten_rule id column is declared as TEXT, but sometimes used with INTEGER values
• bitten_build rev column is declared as TEXT, but sometimes used with INTEGER values

Attaching a quick and dirty patch: works Ok, but it is likely that type conversion should occur in a more appropriate location.

bitten/model.py

@@ -294 +294 @@
         platform = TargetPlatform(env, config=row[0], name=row[1])
         platform.id = id
         cursor.execute("SELECT propname,pattern FROM bitten_rule "
-                       "WHERE id=%s ORDER BY orderno", (id,))
+                       "WHERE id=%s ORDER BY orderno", (str(id),))
         for propname, pattern in cursor:
             platform.rules.append((propname, pattern))
         return platform
@@ -500 +500 @@
         if config is not None:
             where_clauses.append(("config=%s", config))
         if rev is not None:
-            where_clauses.append(("rev=%s", rev))
+            where_clauses.append(("rev=%s", str(rev)))
         if platform is not None:
             where_clauses.append(("platform=%s", platform))
         if slave is not None:

See ​ticket:8379 for a related ticket

[wbell]

Is this not fixed by [639]-[641]?

[Emmanuel Blot <manu.blot@…>]

Replying to wbell:

Is this not fixed by [639]-[641]?

No, it only fixes one error out of three. I just found another one:

bitten/model.py

@@ -223 +223 @@
             build.delete()
 
         cursor = db.cursor()
-        cursor.execute("DELETE FROM bitten_rule WHERE id=%s", (self.id,))
+        cursor.execute("DELETE FROM bitten_rule WHERE id=%s", (str(self.id),))
         cursor.execute("DELETE FROM bitten_platform WHERE id=%s", (self.id,))
         if handle_ta:
             db.commit()
@@ -294 +294 @@
         platform = TargetPlatform(env, config=row[0], name=row[1])
         platform.id = id
         cursor.execute("SELECT propname,pattern FROM bitten_rule "
-                       "WHERE id=%s ORDER BY orderno", (id,))
+                       "WHERE id=%s ORDER BY orderno", (str(id),))
         for propname, pattern in cursor:
             platform.rules.append((propname, pattern))
         return platform
@@ -500 +500 @@
         if config is not None:
             where_clauses.append(("config=%s", config))
         if rev is not None:
-            where_clauses.append(("rev=%s", rev))
+            where_clauses.append(("rev=%s", str(rev)))
         if platform is not None:
             where_clauses.append(("platform=%s", platform))
         if slave is not None:

[osimons]

I'll look at it.

[osimons]

See also attachment:ticket:318:bitten_model.patch​ that identifies many Postgres casting issues, and check that all identified issues are covered by [639:641] (#390) and the patch on this ticket.

[osimons]

attachment:ticket:288:bitten-postgres8.3.patch​ is another patch covering type issues with Progress. Remember to review this patch as well to see if all issues are identified.

[jhampton]

Replying to Emmanuel Blot <manu.blot@…>:

Replying to wbell:

Is this not fixed by [639]-[641]?

No, it only fixes one error out of three. I just found another one:

Did you actually update your install? It looks as though the rev used for your diff was 629 (pre wbell's changes)

The id issues should be fixed now by [639] changing the schema to an integer column for id. The str(rev) change is added in [640] and [641]. I can't find any other location where rev would cause a problem. Additionally, I'm running the latest trunk with PG 8.3 and haven't had any type issues.

I'm going to close this ticket as worksforme in a few days if I don't hear anything back to the contrary

[eblot]

Yes it has been fixed, sorry.