Edgewall Software
Modify

Opened 16 years ago

Last modified 15 years ago

#307 new defect

Log output substitutes out PWD

Reported by: kate Owned by: cmlenz
Priority: major Milestone: 0.6.1
Component: Build slave Version: 0.5.3
Keywords: Cc:
Operating System: BSD

Description

shtools.py:

out.replace(ctxt.basedir + os.sep, '')
   .replace(ctxt.basedir, '')

(likewise for .err).

This means that the log output cannot be trusted; for example <sh:exec executable="pwd"/> gives blank output.

My guess is that you're subtituting this away because relative paths look prettier in the logs. However, this is terribly confusing for more complex situations.

It's also inconsistent against bitten-slave's output to stdout, which does not perform this substitution.

I spent a frustrating evening wading through ktrace output checking syscalls before I eventually realised the logs themselves were being doctored with.

Attachments (0)

Change History (2)

comment:1 Changed 16 years ago by kate

Maybe a nice alternative would be to substitute it with something themable in CSS, so that it can be seen to be visually different. Perhaps <span class="pwd">$PWD</span>, which I'd have show in another colour.

comment:2 Changed 15 years ago by osimons

  • Milestone changed from 0.6 to 0.6.1

Add Comment

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain cmlenz.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.