Edgewall Software
Modify

Opened 17 years ago

Closed 15 years ago

#238 closed defect (worksforme)

Repeated images in timeline after builds complete

Reported by: jgerlach@… Owned by: cmlenz
Priority: trivial Milestone:
Component: Trac plugin Version: dev
Keywords: Cc:
Operating System: Linux

Description

In version 0.6, the "hammer" icon repeats across the whole line in timeline view.

"Build of {build config label [changeset rev]} on {slave} completed" is not visible due to repeated background icon.

Adding "background-repeat:no-repeat;" to htdocs/bitten.css stops the repeat but the time is still hidden by the single icon.

Modified css code

/* Timeline styles */
#content.timeline dt.successbuild, #content.timeline dt.successbuild a {
  background-image: url(bitten_build.png) !important;
  background-repeat: no-repeat;
}
#content.timeline dt.failedbuild, #content.timeline dt.failedbuild a {
  background-image: url(bitten_buildf.png) !important;
  background-repeat: no-repeat;
}

Attachments (0)

Change History (5)

comment:1 Changed 17 years ago by bitten@…

I get this too in Firefox 2 and IE7, running Bitten r519. Having played around this appears to be because Bitten isn't filling the anchor tag surrounding the event title in the Timeline view.

For example

<dt class="successbuild">
  <a>
    <span class="time">15:31</span> Build of <em>Test [13]</em> on Windows completed
  </a>
</dt>

Filling the href property of the anchor tag fixes the problem:

<dt class="successbuild">
  <a href="http://localhost:8000/trac2/build/Test/15">
    <span class="time">16:11</span> Build of <em>Test [15]</em> on Windows completed
  </a>
</dt>

I'll see if I can figure out how to fix the code.

comment:2 Changed 17 years ago by anonymous

Looks like a bug in Trac. Fix is in Trac Changset 6537.

comment:3 Changed 17 years ago by thomas_mueller_ffb

I did see this with trac-0.11b1 - in this case the modification of the css did help but not with trac-trunk (>r6600)

->proposal apply the css patch - doesn't hurt - can help.

comment:4 Changed 15 years ago by osimons

  • Milestone changed from 0.6 to 0.6.1

comment:5 Changed 15 years ago by osimons

  • Milestone 0.6.1 deleted
  • Resolution set to worksforme
  • Status changed from new to closed

I'm just closing this one. It is a fix for a bug that was fixed for Trac 0.11dev long before '0.11.0 final' was released, and changes to Bitten makes no sense now seeing that is the current minumum requirement for trunk.

Add Comment

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain cmlenz.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.