builds get stuck on "In progress"

[jabs@…]

build master gets stuck on "in progress" when initiating a build on a slave fails No more builds are produced until re-registering slave/invalidating build Problem might be the config name is starting with a number...

master log:

2006-03-29 10:29:51,452 [bitten.master] INFO: Registered slave "igor"
2006-03-29 10:30:24,404 [bitten.master] INFO: Initiating build of "1_1_minimum" on slave igor
2006-03-29 10:30:24,439 [bitten.beep] ERROR: '1_1_minimum'
Traceback (most recent call last):
  File "/usr/lib/python2.3/asyncore.py", line 69, in read
    obj.handle_read_event()
  File "/usr/lib/python2.3/asyncore.py", line 390, in handle_read_event
    self.handle_read()
  File "/usr/lib/python2.3/asynchat.py", line 136, in handle_read
    self.found_terminator()
  File "build/bdist.linux-i686/egg/bitten/util/beep.py", line 313, in found_terminator
  File "build/bdist.linux-i686/egg/bitten/util/beep.py", line 346, in _handle_frame
  File "build/bdist.linux-i686/egg/bitten/util/beep.py", line 497, in handle_data_frame
  File "build/bdist.linux-i686/egg/bitten/master.py", line 193, in handle_reply
KeyError: '1_1_minimum'
          ^^^^^^^^^^^^^^
          maybe Problem with non-alpha char??

client says: (probably irrelevant)

[INFO    ] Registering with build master as igor
[DEBUG   ] Properties: {'machine': 'i686', 'version': '2.4.27-2-686-smp', 'os': 'Linux', 'processor': '', 'family': 'posix'}
[DEBUG   ] Sending frame [MSG 1 0 . 0 165]
[DEBUG   ] Handling frame [RPY 1 0 . 0 43]
[INFO    ] Registration successful
[DEBUG   ] Handling frame [MSG 1 0 . 43 332]
[DEBUG   ] Sending frame [RPY 1 0 . 165 48]

[anonymous]

and next time, i'll use formatting, promised...

[cmlenz]

I can't really imagine this has anything to do with the config name starting (or containing) non-alpha characters. Have you actually tried changing the name to alpha-only, and if so, did that fix the problem? Did you try changing it back to the original value after that?

[jabs@…]

still, this seems to be the case. a config named "1mini" throws exactly as above in the master, the same config named "mini1" runs fine. bitten_config content seems ok, both 1mini and mini1 are in the db, i checked with sqlite3 cmdline client. svn revision is 354 btw. trac is 0.9-stable rev2979

maybe just force the config name to start with alpha-char. its sane and no showstopper.

[jabs@…]

a patch to only accept names that don't start with a digit

Index: web_ui.py
===================================================================
--- web_ui.py	(Revision 358)
+++ web_ui.py	(Arbeitskopie)
@@ -238,7 +238,10 @@
         if not re.match(r'^[\w.-]+$', name):
             raise TracError('The field "name" may only contain letters, '
                             'digits, periods, or dashes.', 'Invalid field')
-
+        if re.match(r'^\d+.*',name):
+            raise TracError('The field name must not start with a digit',
+                            'Invalid field')
+        
         path = req.args.get('path', '')
         repos = self.env.get_repository(req.authname)
         max_rev = req.args.get('max_rev') or None

[osimons]

The Beep protocol is gone, and I've tested a config named '1mini' on latest trunk. I can see no such issue anymore.