Relative path in Bitten causes svn assertion that crashes server (Apache/standalone tracd)

[allarddijk]

Actions to reproduce:

1. Go to Trac Admin Builds.Configurations - Add Configuration
2. You see 3 fields, fill the following information and submit:
   • name: myName
   • label: myLabel
   • Paths: .
3. Apache service crashes (SVN module crashes according to Apache log)

Running on: Apache/2.2.9(Win32) SVN/1.5.2 mod_python/3.3.1 Python/2.5.2 mod_auth_sspi/1.0.4 DAV/2 Server. Trac 0.11.6

This is now upstream on trac as ​ticket 9626

[trac@…]

It also kills the trac standalone process, if you use that instead of Apache.

This is the error, btw, that the reporter forgot to include:

python: subversion/libsvn_subr/path.c:115: svn_path_join: Assertion `svn_path_is_canonical(component, pool)' failed.

[osimons]

Rescheduling. Should be fixed.

[dfraser]

Cleaned up syntax and clarified summary

[dfraser]

The crash comes from the following place:

  /home/davidf/work/upstream/bitten-git/bitten/admin.py(240)_create_config()
-> warnings = self._update_config(req, config)
  /home/davidf/work/upstream/bitten-git/bitten/admin.py(288)_update_config()
-> node = repos.get_node(path, max_rev)
  /home/davidf/work/upstream/trac/trac/versioncontrol/cache.py(235)get_node()
-> return self.repos.get_node(path, rev)
  /home/davidf/work/upstream/trac/trac/versioncontrol/svn_fs.py(438)get_node()
-> return SubversionNode(path, rev, self, self.pool)
> /home/davidf/work/upstream/trac/trac/versioncontrol/svn_fs.py(672)__init__()
-> node_type = fs.check_path(self.root, self._scoped_path_utf8, pool)

At this point, self._scoped_path_utf8 is '.'

It seems insane to me that the fs.check_path crashes with an assertion error here.

We need to find out how trac guards against such things - I can't see anything in versioncontrol/api.py that would allow us to easily prevent this.

[dfraser]

Lo,

{ echo 'GET /trac/browser/. HTTP/1.0' ; echo ; } | telnet localhost 8001

crashes trac with exactly the same assertion. Methinks this should be relegated to a trac bug since we're relying on their version control etc

NB trying this with Firefox or wget to the URL fails as it seems to internally reform it and remove the trailing . before passing it on

[osimons]

Agree, raise it as a Trac bug.

[allarddijk]

Thanks for investigation. Reported to Trac on this ticket : ​http://trac.edgewall.org/ticket/9626

Please close this ticket

[dfraser]

Marking as duplicate (of the upstream bug ​http://trac.edgewall.org/ticket/9626)

[dfraser]

For reference, ​http://trac.edgewall.org/ticket/9626 is now fixed