Edgewall Software

Ticket #450 (closed defect: fixed)

Opened 5 years ago

Last modified 4 years ago

prevnext_nav() takes at least 3 arguments (2 given)

Reported by: Olaf Meeuwissen <olaf@…> Owned by: osimons
Priority: critical Milestone: 0.6
Component: General Version: dev
Keywords: Cc:
Operating System:

Description

Just a heads up but  trac:changeset:8597 breaks the /build/configuration page with a traceback. The relevant change is in trac.web.chrome.py. Basically, prevnext_nav() changed from

def prevnext_nav(req, label, uplabel=None):

to

def prevnext_nav(req, prev_label, next_label, up_label=None):

A fix would be pretty trivial if one does not have to address backward compatibility with Trac-0.11.x. But if you need to fix this so it works with that version as well as Trac's trunk, I don't see an easy fix.

Suggestions, anyone?

Attachments

prevnext_nav.diff Download (0.9 KB) - added by Olaf Meeuwissen <olaf@…> 5 years ago.

Change History

Changed 5 years ago by osimons

I don't test Bitten with Trac trunk (0.12dev), so I won't be looking into this quite yet.

Hint: You can use trac.util.arity(fn) to get the count of arguments for the function, and pass arguments accordingly.

Changed 5 years ago by Olaf Meeuwissen <olaf@…>

Changed 5 years ago by Olaf Meeuwissen <olaf@…>

Thanks for the clue bat.

The prevnext_nav.diff Download is perhaps a bit ugly but it works for me. Now Bitten trunk works with both Trac  trunk before (and by extension  Trac-0.11) and  after the prevnext_nav() changes.

Changed 5 years ago by cmlenz

Patch looks good to me, had to apply it to get Bitten running with Trac trunk, and it works as advertised.

Changed 4 years ago by osimons

  • owner set to osimons
  • milestone changed from 0.6.1 to 0.6

Verified. Committed compat code in [801]. Will merge to 0.6.x.

Changed 4 years ago by osimons

  • status changed from new to closed
  • resolution set to fixed

...and closing.

Add/Change #450 (prevnext_nav() takes at least 3 arguments (2 given))

Author


E-mail address and user name can be saved in the Preferences.


Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
 
Note: See TracTickets for help on using tickets.