Permission on SVN can break the server (Patch Inside)

[andrea.tomasini@…]

Hi all,

I had a problem with the trunk version update related to the right

of the user to access a specific branch of the SVN repository. The assumption that all the branches are open to everybody is not sustainable :-)

Index: bitten/queue.py
===================================================================
--- bitten/queue.py     (revision 653)
+++ bitten/queue.py     (working copy)
@@ -50,7 +50,7 @@
         db = env.get_db_cnx()
     try:
         node = repos.get_node(config.path)
-    except NoSuchNode, e:
+    except Exception, e:
         env.log.warn('Node for configuration %r not found',                 config.name,
                                 exc_info=True)
         return

This replaces the No Such Node? with a generic exception, cause it might be the node is existing but the current user can't access it. There may be a better way of solving it, putting the list (tuple) of all the possible exceptions :-)

For now it works, at least I can access the server no 500 anymore :-)

[osimons]

Agree, and agree to keep it simple. Catch all types, and log a warning. I'll fix it.

[osimons]

Committed in [655]. Thanks!