Edgewall Software

Ticket #574 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

verbose flag in svntools should be converted to boolean

Reported by: Neil Muller Owned by:
Priority: minor Milestone: 0.6
Component: Recipe commands Version: 0.6b2
Keywords: Cc:
Operating System: BSD

Description

The verbose flag to the svn: commands is passed in as a string, but treated as a boolean when testing. This leads to the following recipes behaving identically:

<svn:checkout url="file:///home/neil/tmp/CTPUG/bitten-sprint/trac/test-svn"
        path="${path}" revision="${revision}" verbose="false" />

and

<svn:checkout url="file:///home/neil/tmp/CTPUG/bitten-sprint/trac/test-svn"
        path="${path}" revision="${revision}" verbose="true" />

and differing from the recipe excluding the verbose flag.

This is somewhat unexpected.

Attachments

verbose.diff Download (0.7 KB) - added by Neil Muller 2 years ago.
simple patch to verbose handling

Change History

Changed 2 years ago by Neil Muller

simple patch to verbose handling

Changed 2 years ago by Neil Muller

Simple patch to make verbose="False" work. This still accepts verbose="foo" as true, which should perhaps be flagged as an error.

Changed 2 years ago by hodgestar

  • status changed from new to closed
  • resolution set to fixed

Fixed in r847 and backported to 0.6.x in r848. Thanks for the patch!

Add/Change #574 (verbose flag in svntools should be converted to boolean)

Author


E-mail address and user name can be saved in the Preferences.


Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
 
Note: See TracTickets for help on using tickets.